updated BERT processing to current interface #1223
Merged
+247
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @piotrekp1 - Thanks for adding this! I'll accept it right now without changes, but in a future PR could you move it to trax/data instead and add a simple unit test there? (That package should have examples tests with testdata that will make this easy). |
|
@henrykmichalewski as FYI |
|
Hi @afrozenator. I'll do that, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts old code to new interface. For now it's just fine-tuning bert of chosen glue dataset without evaluating on test set
I didn't use SubwordTextEncoder because it gives different token_ids on words that consist of more than one token (e.g. "neglecting").
I didn't upgrade tfds_stream to data_stream, because it might be necessary in BERT models to be able to do processing after batching, so this is to be revisited after implementing more BERT family models.